Skip to content

Fix tupleTypeFromSeq for XXL tuples #21782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

joroKr21
Copy link
Member

Fixes #21779

Copy link
Contributor

@bracevac bracevac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bracevac bracevac merged commit 78cff1b into scala:main Oct 16, 2024
26 checks passed
@joroKr21 joroKr21 deleted the bugfix/tuple-type-seq branch October 16, 2024 11:10
@WojciechMazur WojciechMazur added this to the 3.6.3 milestone Dec 9, 2024
xerial added a commit to xerial/sbt-pack that referenced this pull request Jul 17, 2025
This version includes a fix for scala/scala3#21782

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
xerial added a commit to xerial/sbt-pack that referenced this pull request Jul 20, 2025
* feature: sbt-2 support

* Convert HashsedVirtualFileRef to File

* fix

* reformat

* fix packArchive

* Update Scala 3 to 3.7.1

This version includes a fix for scala/scala3#21782

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update sbt 2.0 to M4

Use the latest sbt 2.0.0-M4 for Scala 3 cross-compilation

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix implicit ordering type for Scala 3 compatibility

Explicitly specify the Ordering[VersionString] type for the implicit value
to resolve compilation errors in Scala 3.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix addArtifact calls for sbt 1.x compatibility

Restore the Runtime configuration prefix for addArtifact calls to ensure
compatibility with sbt 1.x. The archive-modules scripted test was failing
without this configuration.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix PackPlugin imports for sbt 2 compatibility

Replace `import xerial.sbt.pack.PackPlugin._` with explicit references
to `PackPlugin.publishPackArchives` to ensure compatibility with sbt 2.x
where the import behavior has changed.

Updated:
- src/sbt-test/sbt-pack/archive-modules/build.sbt
- README.md

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Improve sbt 2.x compatibility for publishPackArchives

- Add publishPackArchives to autoImport for easier access
- Remove explicit PackPlugin imports from archive-modules test
- Update README.md to use the simpler syntax

Note: There's still an issue with sbt 2.0.0-M4 scripted tests not finding
the plugin properly, which appears to be a limitation of the current
milestone release.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Run scalafmtAll to format code

Applied automatic code formatting to ensure consistent style.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix deprecated syntax in scripted tests

Updated scripted tests to use modern sbt syntax:
- Replace deprecated slash syntax (module/task) with spaces (module / task)
- Replace deprecated 'in' syntax (key in scope) with slash syntax (scope / key)

These changes follow the migration guide at:
https://www.scala-sbt.org/1.x/docs/Migrating-from-sbt-013x.html#slash

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update CI Java versions: skip 8/11, add 24

- Remove Java 8 and 11 from CI to save time
- Keep Java 17 and 21 as current LTS versions
- Add Java 24 for testing with latest version

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update sbt to 1.11.3

Update to the latest sbt version 1.11.3

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix exclude-test-config test hanging issue

- Rename 'client' subproject to 'clientApp' to avoid triggering sbt's
  experimental thin client mode (sbt/sbt#5314)
- Update all references in build.sbt and test files
- Fix expected JAR name to match sbt's normalized naming (clientapp-0.1.jar)

This resolves the test hanging when running with sbt 1.11.x

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update exclude-test-config test to use sbt 1.11.3

* Add explicit PackPlugin imports in test build files for sbt 2.x compatibility

sbt 2.x requires explicit imports for plugin references in build files. Added
`import xerial.sbt.pack.PackPlugin` to all scripted test build.sbt files to
ensure compatibility with both sbt 1.x and 2.x versions.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Split scripted test CI for sbt-1 and sbt-2

- Created separate CI jobs for sbt 1.x and sbt 2.x testing
- test_sbt1_plugin runs with Scala 2.12.20 (sbt 1.x)
- test_sbt2_plugin runs with Scala 3.7.1 (sbt 2.0.0-M4)
- Both jobs test across Java 17, 21, and 24

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Drop Java 17 from CI matrix

- Removed Java 17 from both sbt-1 and sbt-2 test jobs
- Tests now run only on Java 21 and 24

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update syntax for Scala 3 compatibility

- Replace infix operators with method calls (startsWith)
- Use wildcard type `?` instead of `_` for existential types
- Add parentheses for method calls (log.debug, log.info)
- Update evaluate method call syntax

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Remove unnecessary PackPlugin imports from scripted tests

- Removed import xerial.sbt.pack.PackPlugin from 14 build.sbt files
- The import is unnecessary since the plugin is already enabled
- Cleaned up empty lines left after removing imports

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Update scripted tests to use Scala 2.13.16

- Updated all scripted test build.sbt files from Scala 2.12.20 to 2.13.16
- This ensures tests use at least Scala 2.13.16 as requested
- Updated 14 test project files

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Fix scripted test expectations for Scala 2.13

- Updated nested-project test to expect Scala 2.13 artifacts
- Changed hardcoded _2.12 references to _2.13 in test assertions
- This fixes test failures after upgrading tests to Scala 2.13.16

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Use ++ 3 instead of ++ 3.7.1 in CI workflow

- Simplified Scala 3 version specification in sbt 2.x tests
- Using ++ 3 will use the default Scala 3 version from build.sbt

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Use ++ 2.12 instead of ++ 2.12.20 in CI workflow

- Simplified Scala 2.12 version specification in sbt 1.x tests
- Using ++ 2.12 will use the default Scala 2.12 version from build.sbt

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

* Disable sbt 2.x CI tests temporarily

- Commented out sbt 2.x test job due to Scala 3.7 compatibility issues
- Will be re-enabled once sbt 2 supports Scala 3.7 (see #583)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expr.ofTupleFromSeq return incorrect value if TupleXXL
3 participants